Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
熊鹏飞
/
xxljob220
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
5c74f514
authored
Nov 19, 2019
by
许雪里
Committed by
GitHub
Nov 19, 2019
Browse files
Options
_('Browse Files')
Download
Plain Diff
Merge pull request #1070 from wybrono/wy-triggerparam-logdatetime
修正TriggerParam的LogDateTim为LogDateTime
parents
2ced6010
7f969ae1
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
13 additions
and
13 deletions
xxl-job-admin/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java
xxl-job-admin/src/test/java/com/xxl/job/executor/ExecutorBizTest.java
xxl-job-core/src/main/java/com/xxl/job/core/biz/model/TriggerParam.java
xxl-job-core/src/main/java/com/xxl/job/core/thread/JobThread.java
xxl-job-core/src/test/java/com/xxl/job/core/biz/impl/ExecutorBizImplTest.java
xxl-job-admin/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java
View file @
5c74f514
...
...
@@ -116,7 +116,7 @@ public class XxlJobTrigger {
triggerParam
.
setExecutorBlockStrategy
(
jobInfo
.
getExecutorBlockStrategy
());
triggerParam
.
setExecutorTimeout
(
jobInfo
.
getExecutorTimeout
());
triggerParam
.
setLogId
(
jobLog
.
getId
());
triggerParam
.
setLogDateTim
(
jobLog
.
getTriggerTime
().
getTime
());
triggerParam
.
setLogDateTim
e
(
jobLog
.
getTriggerTime
().
getTime
());
triggerParam
.
setGlueType
(
jobInfo
.
getGlueType
());
triggerParam
.
setGlueSource
(
jobInfo
.
getGlueSource
());
triggerParam
.
setGlueUpdatetime
(
jobInfo
.
getGlueUpdatetime
().
getTime
());
...
...
xxl-job-admin/src/test/java/com/xxl/job/executor/ExecutorBizTest.java
View file @
5c74f514
...
...
@@ -45,7 +45,7 @@ public class ExecutorBizTest {
triggerParam
.
setGlueSource
(
null
);
triggerParam
.
setGlueUpdatetime
(
System
.
currentTimeMillis
());
triggerParam
.
setLogId
(
1
);
triggerParam
.
setLogDateTim
(
System
.
currentTimeMillis
());
triggerParam
.
setLogDateTim
e
(
System
.
currentTimeMillis
());
// do remote trigger
String
accessToken
=
null
;
...
...
xxl-job-core/src/main/java/com/xxl/job/core/biz/model/TriggerParam.java
View file @
5c74f514
...
...
@@ -16,7 +16,7 @@ public class TriggerParam implements Serializable{
private
int
executorTimeout
;
private
long
logId
;
private
long
logDateTim
;
private
long
logDateTim
e
;
private
String
glueType
;
private
String
glueSource
;
...
...
@@ -74,12 +74,12 @@ public class TriggerParam implements Serializable{
this
.
logId
=
logId
;
}
public
long
getLogDateTim
()
{
return
logDateTim
;
public
long
getLogDateTim
e
()
{
return
logDateTim
e
;
}
public
void
setLogDateTim
(
long
logDateTim
)
{
this
.
logDateTim
=
logDateTim
;
public
void
setLogDateTim
e
(
long
logDateTime
)
{
this
.
logDateTim
e
=
logDateTime
;
}
public
String
getGlueType
()
{
...
...
@@ -132,7 +132,7 @@ public class TriggerParam implements Serializable{
", executorBlockStrategy='"
+
executorBlockStrategy
+
'\''
+
", executorTimeout="
+
executorTimeout
+
", logId="
+
logId
+
", logDateTim
="
+
logDateTim
+
", logDateTim
e="
+
logDateTime
+
", glueType='"
+
glueType
+
'\''
+
", glueSource='"
+
glueSource
+
'\''
+
", glueUpdatetime="
+
glueUpdatetime
+
...
...
xxl-job-core/src/main/java/com/xxl/job/core/thread/JobThread.java
View file @
5c74f514
...
...
@@ -116,7 +116,7 @@ public class JobThread extends Thread{
triggerLogIdSet
.
remove
(
triggerParam
.
getLogId
());
// log filename, like "logPath/yyyy-MM-dd/9999.log"
String
logFileName
=
XxlJobFileAppender
.
makeLogFileName
(
new
Date
(
triggerParam
.
getLogDateTim
()),
triggerParam
.
getLogId
());
String
logFileName
=
XxlJobFileAppender
.
makeLogFileName
(
new
Date
(
triggerParam
.
getLogDateTim
e
()),
triggerParam
.
getLogId
());
XxlJobFileAppender
.
contextHolder
.
set
(
logFileName
);
ShardingUtil
.
setShardingVo
(
new
ShardingUtil
.
ShardingVO
(
triggerParam
.
getBroadcastIndex
(),
triggerParam
.
getBroadcastTotal
()));
...
...
@@ -186,11 +186,11 @@ public class JobThread extends Thread{
// callback handler info
if
(!
toStop
)
{
// commonm
TriggerCallbackThread
.
pushCallBack
(
new
HandleCallbackParam
(
triggerParam
.
getLogId
(),
triggerParam
.
getLogDateTim
(),
executeResult
));
TriggerCallbackThread
.
pushCallBack
(
new
HandleCallbackParam
(
triggerParam
.
getLogId
(),
triggerParam
.
getLogDateTim
e
(),
executeResult
));
}
else
{
// is killed
ReturnT
<
String
>
stopResult
=
new
ReturnT
<
String
>(
ReturnT
.
FAIL_CODE
,
stopReason
+
" [job running,killed]"
);
TriggerCallbackThread
.
pushCallBack
(
new
HandleCallbackParam
(
triggerParam
.
getLogId
(),
triggerParam
.
getLogDateTim
(),
stopResult
));
TriggerCallbackThread
.
pushCallBack
(
new
HandleCallbackParam
(
triggerParam
.
getLogId
(),
triggerParam
.
getLogDateTim
e
(),
stopResult
));
}
}
}
...
...
@@ -202,7 +202,7 @@ public class JobThread extends Thread{
if
(
triggerParam
!=
null
)
{
// is killed
ReturnT
<
String
>
stopResult
=
new
ReturnT
<
String
>(
ReturnT
.
FAIL_CODE
,
stopReason
+
" [job not executed, in the job queue, killed.]"
);
TriggerCallbackThread
.
pushCallBack
(
new
HandleCallbackParam
(
triggerParam
.
getLogId
(),
triggerParam
.
getLogDateTim
(),
stopResult
));
TriggerCallbackThread
.
pushCallBack
(
new
HandleCallbackParam
(
triggerParam
.
getLogId
(),
triggerParam
.
getLogDateTim
e
(),
stopResult
));
}
}
...
...
xxl-job-core/src/test/java/com/xxl/job/core/biz/impl/ExecutorBizImplTest.java
View file @
5c74f514
...
...
@@ -133,7 +133,7 @@ public class ExecutorBizImplTest {
triggerParam
.
setGlueSource
(
null
);
triggerParam
.
setGlueUpdatetime
(
System
.
currentTimeMillis
());
triggerParam
.
setLogId
(
1
);
triggerParam
.
setLogDateTim
(
System
.
currentTimeMillis
());
triggerParam
.
setLogDateTim
e
(
System
.
currentTimeMillis
());
// Act
final
ReturnT
<
String
>
retval
=
executorBiz
.
run
(
triggerParam
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment